Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a gate scene and enriches the main UI with themed styles, labels, and notification support, while updating project and export configurations.
- Integrates a new
gate.tscnand instantiates it inmain.tscn - Enhances UI styling in
main.tscnwithStyleBoxFlatresources and adds Node/Move labels - Extends
MainScene(main_scene.hpp) to manage notifications and new label fields - Adjusts project settings (
project.godot) and export paths/features (export_presets.cfg)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tukang-parkir-simulator/scenes/main.tscn | Instantiated gate, added repeated StyleBoxFlat resources, UI labels and theme overrides |
| tukang-parkir-simulator/scenes/gate.tscn | Introduced gate scene with collision and CSG shape |
| tukang-parkir-simulator/project.godot | Set default texture filter to nearest (0) |
| tukang-parkir-simulator/export_presets.cfg | Updated web/windows export paths and enabled extensions_support |
| test/2.txt | Adjusted test input values |
| src/main_scene/main_scene.hpp | Added imports, label fields, notifications, and input overrides |
Comments suppressed due to low confidence (3)
tukang-parkir-simulator/scenes/main.tscn:216
- [nitpick] The generic name
NodeLabelcould be confused with other labels; consider renaming it toNodeCountLabelto clarify its purpose.
[node name="NodeLabel" type="Label" parent="UI"]
src/main_scene/main_scene.hpp:120
- Add the
overridespecifier to_notificationto clearly indicate it overrides a base class method and catch mismatches at compile time.
void _notification(int p_what);
test/2.txt:2
- The test input changed from
-5to4, which may break parsing logic or expected outcomes; verify the test harness and any assertions are updated accordingly.
4
| @@ -38,6 +39,44 @@ size = Vector2(6, 6) | |||
| data = PackedVector3Array(50, 0, 50, -50, 0, 50, 50, 0, -50, -50, 0, 50, -50, 0, -50, 50, 0, -50) | |||
|
|
|||
| [sub_resource type="StyleBoxFlat" id="StyleBoxFlat_kuqtn"] | |||
There was a problem hiding this comment.
[nitpick] Several StyleBoxFlat sub-resources share identical properties; consider defining a single reusable style resource and referencing it to reduce duplication and simplify future updates.
Suggested change
| [sub_resource type="StyleBoxFlat" id="StyleBoxFlat_kuqtn"] | |
| [sub_resource type="StyleBoxFlat" id="StyleBoxFlat_Shared"] |
| include_filter="" | ||
| exclude_filter="" | ||
| export_path="../../executable/godot cpp template.html" | ||
| export_path="../bin/web/Tukang Parkir Simulator.html" |
There was a problem hiding this comment.
Export paths containing spaces can cause issues in build scripts; consider removing or escaping spaces or using underscores/hyphens.
Suggested change
| export_path="../bin/web/Tukang Parkir Simulator.html" | |
| export_path="../bin/web/Tukang_Parkir_Simulator.html" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.